plugin(language, converter): Respond to SIGINT #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
Frassle
reviewed
Aug 29, 2023
| // | ||
| // The returned channel is used to notify the server that it should | ||
| // stop serving and exit. | ||
| ctx, cancel := signal.NotifyContext(context.Background(), os.Interrupt) |
There was a problem hiding this comment.
Don't we need a defer'd cancel() // dregister the interrupt handler here like in the converter?
There was a problem hiding this comment.
Derp, we do. Good catch. Fixed
abhinav
added a commit
to pulumi/pulumi-dotnet
that referenced
this pull request
Aug 29, 2023
Shut the plugin down gracefully when a SIGINT or CTRL_BREAK signal is received. Related: - pulumi/pulumi#13809 - pulumi/pulumi-yaml#501 Refs pulumi/pulumi#9780
abhinav
added a commit
to pulumi/pulumi-java
that referenced
this pull request
Aug 29, 2023
Shut the plugin down gracefully when a SIGINT or CTRL_BREAK signal is received. Related: - pulumi/pulumi#13809 - pulumi/pulumi-yaml#501 - pulumi/pulumi-dotnet#172 Refs pulumi/pulumi#9780
Configures the language plugin binary to shut down the plugin RPC server when SIGINT is received. This will help the binary exit cleanly when it's time to shut down. This functionality was added in pulumi/pulumi#13795. pulumi/pulumi#13809 contains a similar change for Go, Python, and Node.
abhinav
force-pushed
the
abhinav/sigint
branch
from
01c5139
to
48cab9c
Compare
Frassle
approved these changes
Aug 29, 2023
github-merge-queue bot
pushed a commit
to pulumi/pulumi-dotnet
that referenced
this pull request
Aug 29, 2023
Shut the plugin down gracefully when a SIGINT or CTRL_BREAK signal is received. Related: - pulumi/pulumi#13809 - pulumi/pulumi-yaml#501 Refs pulumi/pulumi#9780
abhinav
added a commit
to pulumi/pulumi-java
that referenced
this pull request
Aug 29, 2023
Shut the plugin down gracefully when a SIGINT or CTRL_BREAK signal is received. Related: - pulumi/pulumi#13809 - pulumi/pulumi-yaml#501 - pulumi/pulumi-dotnet#172 Refs pulumi/pulumi#9780
jkerken
pushed a commit
to algompluecker/pulumi-dotnet
that referenced
this pull request
Jul 24, 2024
Shut the plugin down gracefully when a SIGINT or CTRL_BREAK signal is received. Related: - pulumi/pulumi#13809 - pulumi/pulumi-yaml#501 Refs pulumi/pulumi#9780
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configures the language plugin binary to shut down the plugin RPC server
when SIGINT is received.
This will help the binary exit cleanly when it's time to shut down.
This functionality was added in pulumi/pulumi#13795.
pulumi/pulumi#13809 contains a similar change for Go, Python, and Node.